Skip to content

feat: add feed v2 highlight cards#5836

Merged
idoshamun merged 10 commits intomainfrom
codex/feed-v2-highlights-card
Apr 5, 2026
Merged

feat: add feed v2 highlight cards#5836
idoshamun merged 10 commits intomainfrom
codex/feed-v2-highlights-card

Conversation

@idoshamun
Copy link
Copy Markdown
Member

@idoshamun idoshamun commented Apr 5, 2026

Summary

  • add feedV2 highlight fetching behind a default-on feature flag and normalize highlight feed items
  • port the highlight card into shared feed cards for both grid and list layouts, wired into the feed item renderer
  • add highlight analytics for impression, card click, and individual highlight clicks without wiring real navigation yet

Testing

  • node ./scripts/typecheck-strict-changed.js
  • pnpm exec eslint src/graphql/highlights.ts src/lib/feed.ts src/components/FeedItemComponent.tsx src/hooks/feed/useLogImpression.ts src/hooks/useFeed.ts src/components/Feed.spec.tsx
  • git diff --check
  • attempted NODE_ENV=test pnpm exec jest src/components/Feed.spec.tsx --runInBand --testNamePattern="feedV2 highlight" but local jsdom setup failed before test execution (Cannot read properties of undefined (reading 'testEnvironmentOptions' ))

Follow-ups

  • highlight card positioning still looks like an API-side issue and is intentionally left unresolved in this PR
  • click handling is analytics-only for now; real click behavior will be wired in later

Preview domain

https://codex-feed-v2-highlights-card.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 5, 2026 7:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 5, 2026 7:43pm

Request Review

@idoshamun idoshamun merged commit e961f1e into main Apr 5, 2026
13 checks passed
@idoshamun idoshamun deleted the codex/feed-v2-highlights-card branch April 5, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant