fix: allow non-object JSON/YAML payloads in contextualizer and authorizer responses#3202
Open
Kakadus wants to merge 1 commit intodadrus:releasefrom
Open
fix: allow non-object JSON/YAML payloads in contextualizer and authorizer responses#3202Kakadus wants to merge 1 commit intodadrus:releasefrom
Kakadus wants to merge 1 commit intodadrus:releasefrom
Conversation
…izer responses
The contenttype decoder forced responses into map[string]any, so a
top-level JSON array (e.g. []) or scalar returned by an upstream caused
"failed to unmarshal response: expected { character for map value" and
an HTTP 500. Widen Decoder.Decode to return any; callers already consume
it as any.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #3202 +/- ##
===========================================
+ Coverage 91.27% 91.30% +0.02%
===========================================
Files 281 281
Lines 10800 10800
===========================================
+ Hits 9858 9861 +3
+ Misses 680 678 -2
+ Partials 262 261 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Fixes #3201
Checklist
Description
The contenttype decoder forced responses into map[string]any, so a top-level JSON array (e.g. []) or scalar returned by an upstream caused "failed to unmarshal response: expected { character for map value" and an HTTP 500. Widen Decoder.Decode to return any; callers already consume it as any.