Scripting: Normalize output of FormatBytes

[Epicpkmn11]

The output of FormatBytes() is localized, but it is provided to scripts and some (such as the hacks.guide finalizing script) expect it in the English format. Currently trying to run finalize with any locale that uses , as the decimal separator crashes the script and anything that renames "GB" (ex. French "Go") would cause that script to incorrectly display the no free space error if those languages didn't all use "," separator.

I considered making the Lua version have a flag to enable/disable localization, but I couldn't quite tell what the proper way to do that would be.

[Epicpkmn11]

The lua flag I mentioned in the OP has now been added (thanks @ihaveamac for actually doing the code). lua tested using this script, seems good:

local stat = fs.stat_fs("0:")
print("Default:", ui.format_bytes(stat["free"]))
print("Explicit Normalized:", ui.format_bytes(stat["free"], {use_locale=false}))
print("Localized:", ui.format_bytes(stat["free"], {use_locale=true}))

ui.echo("Press A to exit.")

Edit: And (as seen in line 2) the lua API is unbroken from the previous version

[ihaveamac]

Since this technically changes the Lua behavior this should include an update to the documentation for ui.format_bytes.

[ihaveamac]

#### ui.format_bytes

* `string ui.format_bytes(int bytes[, table opts {bool use_locale}])`

Format a number with `Byte`, `kB`, `MB`, or `GB`.

* **Arguments**
        * `bytes` - Size to format
        * `opts` (optional) - Option flags
                * `use_locale` - Format based on current locale
* **Returns:** formatted string

[Epicpkmn11]

Oh didn't see your second comment so I just wrote it myself 😅

Fixed the stray ; and updated the docs, did it in a force push cause I know I've been asked to keep my commits clean here before sometimes.

[ihaveamac]

It’s fine, yours is better than what I typed up anyway.

[Wolfvak]

about keeping it clean: we can just squash and merge, it's not a big deal

[d0k3]

Squashed and merged, thank you!