Modifications to Cylc entry point to allow coverage collection in Cylc Review#7232
Merged
oliver-sanders merged 6 commits intocylc:masterfrom Mar 11, 2026
Merged
Modifications to Cylc entry point to allow coverage collection in Cylc Review#7232oliver-sanders merged 6 commits intocylc:masterfrom
oliver-sanders merged 6 commits intocylc:masterfrom
Conversation
8 tasks
Member
oliver-sanders
left a comment
oliver-sanders
left a comment
There was a problem hiding this comment.
LGTM, plz tidy up print statements though!
wxtim
commented
Mar 11, 2026
wxtim
commented
Mar 11, 2026
Member
Author
|
I had rather assumed that the print statements were part of the logging if one chose to turn coverage on. Have removed. |
oliver-sanders
approved these changes
Mar 11, 2026
Member
oliver-sanders
left a comment
oliver-sanders
left a comment
There was a problem hiding this comment.
LGTM, plz squash merge.
Co-authored-by: Tim Pillinger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplements #7068, required for tests in cylc/cylc-uiserver#755 to pass
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).included (or explain why tests are not needed).effectively provided by existing tests and the tests in Add Cylc Review (from Cylc 7) cylc-uiserver#755 passing.this is a change that can affect users?.?.xbranch.