Skip to content

Feat.cylc review #7068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wxtim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat.cylc review #7068

wxtim wants to merge 1 commit into from

Conversation

@wxtim
Copy link
Member

@wxtim wxtim commented Nov 7, 2025 •
edited
Loading

Companion to cylc/cylc-uiserver#755

  • Remove cylc review inteception from the wrapper script.
  • Remove dead ends interception of cylc review

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are NOT included: Use the companion UI Server branch to check this PR.
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • This is a feature to be raised against master

@wxtim wxtim self-assigned this Nov 7, 2025
@wxtim wxtim marked this pull request as draft November 7, 2025 15:35
@wxtim wxtim changed the base branch from master to 8.6.x November 7, 2025 15:36
@wxtim wxtim changed the base branch from 8.6.x to master November 7, 2025 15:36
wxtim
wxtim commented Nov 7, 2025
View reviewed changes
wxtim
wxtim commented Nov 7, 2025
View reviewed changes
@hjoliver

This comment was marked as resolved.

Sign in to view
wxtim
wxtim commented Nov 12, 2025
View reviewed changes
wxtim
wxtim commented Nov 12, 2025
View reviewed changes
wxtim
wxtim commented Nov 12, 2025
View reviewed changes
@wxtim wxtim force-pushed the feat.cylc-review branch 8 times, most recently from ee54e4f to ecff754 Compare November 17, 2025 13:45
wxtim
wxtim commented Nov 17, 2025
View reviewed changes
@wxtim wxtim force-pushed the feat.cylc-review branch 4 times, most recently from 466d3e8 to f26e427 Compare November 17, 2025 15:14
@wxtim wxtim closed this Nov 17, 2025
@wxtim wxtim deleted the feat.cylc-review branch November 17, 2025 15:15
@wxtim wxtim restored the feat.cylc-review branch November 17, 2025 15:16
@wxtim wxtim reopened this Nov 17, 2025
@wxtim wxtim force-pushed the feat.cylc-review branch 2 times, most recently from e94ee63 to 599ac83 Compare November 18, 2025 10:08
wxtim
wxtim commented Nov 18, 2025
View reviewed changes
@wxtim wxtim force-pushed the feat.cylc-review branch 2 times, most recently from 2e3e552 to 9e1bbcb Compare November 18, 2025 14:19
@wxtim wxtim added this to the 8.7.0 milestone Nov 28, 2025
@wxtim wxtim mentioned this pull request Nov 28, 2025
Open
8 tasks
@wxtim wxtim marked this pull request as ready for review December 4, 2025 15:58
ChrisPaulBennett
ChrisPaulBennett approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@ChrisPaulBennett ChrisPaulBennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cylc/flow/etc/cylc
fi

# Legacy support for cylc review
if [[ ${0##*/} == "cylc" && ${1:-} == "review" && \
Copy link
Contributor

@ChrisPaulBennett ChrisPaulBennett Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a net benefit that no one has to look at that line of code again

@ChrisPaulBennett ChrisPaulBennett self-requested a review December 15, 2025 09:30
@wxtim wxtim mentioned this pull request Jan 22, 2026
Open
8 tasks
wxtim added a commit to wxtim/cylc-uiserver that referenced this pull request Feb 4, 2026
@wxtim
[skip ci]Turn off bodge that makes branch pass tests without cylc/cyl…
493ecad 
…c-flow#7068 merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisPaulBennett ChrisPaulBennett ChrisPaulBennett approved these changes

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

Assignees

@wxtim wxtim

Labels

None yet

Projects

None yet

Milestone

8.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wxtim @hjoliver @ChrisPaulBennett