-
Notifications
You must be signed in to change notification settings - Fork 95
Validation of order of initial/start/stop/final cycle points #6874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wxtim
wants to merge
2
commits into
cylc:8.6.x
Choose a base branch
from
wxtim:fix.validation_NNN_cycle_pt
base: 8.6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+118
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7708d2 to
223fefe
Compare
Member
Author
|
Broken the one test which did test any case |
ef8574c to
f81634e
Compare
MetRonnie
reviewed
Aug 5, 2025
wxtim
commented
Aug 14, 2025
Member
|
(assigning commenters as reviewers) |
Member
Author
|
Draft because it's broken loads of tests |
badaf1f to
c5cbfd1
Compare
d68f704 to
91d3662
Compare
91d3662 to
9123c76
Compare
Member
Author
|
@MetRonnie @hjoliver Poke. |
Member
Author
|
Bump |
Member
|
Unresolved
question
Also, base branch is 8.6.x but milestone is 8.7.0 - one of these needs to change |
9123c76 to
b59034d
Compare
768d4ac to
41c7687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6866
Follow-up to #4302
Apparently there was no systematic validation of whether users were supplying sensible values for these, except in a small number of cases.
In this PR, I write a thorough set of cases and ensure that they all pass.
Currently this targets 8.4.x, but I understand that given the refactoring it might be sensible enough to target 8.6.0.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.