Skip to content

Conversation

@wxtim
Copy link
Member

@wxtim wxtim commented Jul 23, 2025

Closes #6866

Follow-up to #4302

Apparently there was no systematic validation of whether users were supplying sensible values for these, except in a small number of cases.

In this PR, I write a thorough set of cases and ensure that they all pass.

Currently this targets 8.4.x, but I understand that given the refactoring it might be sensible enough to target 8.6.0.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim requested a review from MetRonnie July 23, 2025 15:47
@wxtim wxtim self-assigned this Jul 23, 2025
@wxtim wxtim force-pushed the fix.validation_NNN_cycle_pt branch from e7708d2 to 223fefe Compare July 23, 2025 15:49
@wxtim wxtim marked this pull request as draft July 25, 2025 07:08
@wxtim
Copy link
Member Author

wxtim commented Jul 25, 2025

Broken the one test which did test any case

@wxtim wxtim marked this pull request as ready for review July 25, 2025 08:22
@wxtim wxtim force-pushed the fix.validation_NNN_cycle_pt branch 2 times, most recently from ef8574c to f81634e Compare July 28, 2025 09:56
@MetRonnie MetRonnie added this to the 8.4.x milestone Jul 29, 2025
@wxtim wxtim modified the milestones: 8.4.x, 8.5.x Aug 11, 2025
@oliver-sanders oliver-sanders modified the milestones: 8.5.x, 8.7.0 Aug 11, 2025
@oliver-sanders
Copy link
Member

(assigning commenters as reviewers)

@wxtim wxtim marked this pull request as draft August 27, 2025 08:08
@wxtim
Copy link
Member Author

wxtim commented Aug 27, 2025

Draft because it's broken loads of tests

@wxtim wxtim force-pushed the fix.validation_NNN_cycle_pt branch from badaf1f to c5cbfd1 Compare October 2, 2025 15:45
@wxtim wxtim changed the base branch from 8.4.x to 8.6.x October 2, 2025 15:45
@wxtim wxtim force-pushed the fix.validation_NNN_cycle_pt branch from d68f704 to 91d3662 Compare October 16, 2025 14:13
@wxtim wxtim marked this pull request as ready for review October 16, 2025 14:22
@wxtim wxtim force-pushed the fix.validation_NNN_cycle_pt branch from 91d3662 to 9123c76 Compare December 9, 2025 11:07
@wxtim
Copy link
Member Author

wxtim commented Dec 9, 2025

@MetRonnie @hjoliver Poke.

@wxtim
Copy link
Member Author

wxtim commented Jan 9, 2026

Bump

@MetRonnie MetRonnie added the question Flag this as a question for the next Cylc project meeting. label Jan 9, 2026
@MetRonnie
Copy link
Member

Unresolved question Flag this as a question for the next Cylc project meeting. : #6874 (comment)

Also, base branch is 8.6.x but milestone is 8.7.0 - one of these needs to change

@wxtim wxtim marked this pull request as draft January 12, 2026 09:39
@wxtim wxtim modified the milestones: 8.7.0, 8.6.x Jan 12, 2026
@wxtim wxtim force-pushed the fix.validation_NNN_cycle_pt branch from 9123c76 to b59034d Compare January 12, 2026 11:22
@wxtim wxtim marked this pull request as ready for review January 12, 2026 12:48
@wxtim wxtim force-pushed the fix.validation_NNN_cycle_pt branch from 768d4ac to 41c7687 Compare January 12, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Flag this as a question for the next Cylc project meeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants