Overridable classes to record and export events and audit logs #10545
Open
Overridable classes to record and export events and audit logs #10545
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
Author
|
@SpecLad review pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR is mainly a code restructuring change for events and audit logging. The goal is to make both recording and export logic overridable via settings, without changing the existing behavior.
What changed
Added a new
cvat/apps/events/record.pymodule withDefaultEventsRecorderMoved core event recording logic there:
request_info,record_server_event,record_client_eventsUpdated
handlers.pyso event handler functions keep their current role, but delegate recording to the recorder classEnhanced event serializer class (payload must be an object)
Updated
views.pyso client event logging also goes through the same recorder abstractionAdded a settings-based extension point for the recorder:
EVENTS_RECORDER_CLASSRefactored
cvat/apps/events/export.pyaroundDefaultEventsExporterAdded a settings-based extension point for the exporter:
EVENTS_EXPORTER_CLASSUpdated export entry points to use the resolved exporter class
Result
Functionally, this PR is intended to preserve the current implementation. The main change is structural: event recording and export are now organized around explicit, overridable classes, which makes them easier to customize in downstream repositories.
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.