Open
Conversation
@tag marked with `scope=mod` are shared across packages of the same module => it allow to define some @tag once in the module and reuse them in several packages/files Fixes cue-lang#1070 Signed-off-by: Bertrand Cachet <bertrand.cachet@exoscale.ch>
bcachet
force-pushed
the
feat/tags-across-packages
branch
from
ddef495 to
869f72f
Compare
seh
reviewed
Mar 30, 2026
cue/load/instances.go
Outdated
| // the same module. These tags are injected even when their package is | ||
| // not a root package but is merely imported. | ||
| if c.Module != "" { | ||
| visited := map[string]bool{} |
Contributor
There was a problem hiding this comment.
Here, it looks like you know the minimum required size of the map, but then you pass it down through findModuleScopeTags recursively, and continue adding to it. Can you estimate how many entries you'll wind up with?
Suggested change
| visited := map[string]bool{} | |
| visited := make(map[string]bool, len(a)) |
Also, I'd rather see map[string]struct{} here, but you'd need to adjust your findModuleScopeTags signature to play along.
Signed-off-by: Bertrand Cachet <bertrand.cachet@exoscale.ch>
bcachet
force-pushed
the
feat/tags-across-packages
branch
from
8060b49 to
ec6d5f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tags marked with
scope=modare shared across packages of the same module=> it allow to define some tag once in the module and reuse them in several packages/files
Note
Fix issue reported in #1070