This repository was archived by the owner on Mar 27, 2019. It is now read-only.
Fix division by zero in _wheelZoom#986
Open
JessThrysoee wants to merge 2 commits intocubiq:masterfrom
JessThrysoee:wheelzoom_division_by_zero
Open
Fix division by zero in _wheelZoom#986JessThrysoee wants to merge 2 commits intocubiq:masterfrom JessThrysoee:wheelzoom_division_by_zero
JessThrysoee wants to merge 2 commits intocubiq:masterfrom
JessThrysoee:wheelzoom_division_by_zero
Conversation
Use an alternative way to get the sign of deltaY and make it more obvious that it is only used to get a signed unity factor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an alternative way to get the sign of deltaY and make it more
obvious that it is only used to get a signed unity factor.