This repository was archived by the owner on Mar 27, 2019. It is now read-only.
Can now target different scroller#1022
Open
fanmanpro wants to merge 2 commits intocubiq:masterfrom
fanmanpro:master
Open
Can now target different scroller#1022fanmanpro wants to merge 2 commits intocubiq:masterfrom fanmanpro:master
fanmanpro wants to merge 2 commits intocubiq:masterfrom
fanmanpro:master
Conversation
Added an optional parameter to iScroll in order to target a different scroller element instead of always using the first child element
Added: snapWait option that when set to true, you can only goToPage to the next section if the previous snap animation/transition finised. Fixed: When snap is set to true and you mouseWheelScroll up at the first page or mouseWheelScroll down at the last page, you cannot scroll anymore. Should also improve performance of goToPage function in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an optional parameter to iScroll constructor in order to target a different scroller element instead of always using the first child element.
P.S. Might be better to make this an option instead of a parameter...