This repository was archived by the owner on Mar 27, 2019. It is now read-only.
add VUPBoundary VDOWNboundary options so that pull-refresh is possible when content didn't overflow wrapper#1013
Open
eeandrew wants to merge 2 commits intocubiq:masterfrom
Open
add VUPBoundary VDOWNboundary options so that pull-refresh is possible when content didn't overflow wrapper#1013eeandrew wants to merge 2 commits intocubiq:masterfrom
eeandrew wants to merge 2 commits intocubiq:masterfrom
Conversation
…e when content does not overflow the wrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull-refresh is only possible when wrapper is overflowed by content. Obviously, this will be a bug in situations where content(scroller) is not long enough to overflow the wrapper.
So I add VUPBoundary and VDOWNboundary options. By setting them to FALSE, content can still scroll even if the content is short and the wrapper is not over-flowed.