fix(docker): upgrade to Debian Trixie to remediate CVE-2023-45853#10751
Open
whitehat101 wants to merge 1 commit intocube-js:masterfrom
Open
fix(docker): upgrade to Debian Trixie to remediate CVE-2023-45853#10751whitehat101 wants to merge 1 commit intocube-js:masterfrom
whitehat101 wants to merge 1 commit intocube-js:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#7499
#9977 (also patches other CVEs in addition to CVE-2023-45853)
Summary
Upgrades all Dockerfile base images from Debian 12 (Bookworm) to Debian 13 (Trixie) to remediate CVE-2023-45853, a heap-based buffer overflow in MiniZip bundled within
zlib. This PR also updates Python 3.11 to 3.13 and OpenJDK 17 to 21 to match Debian Trixie's available packages.Files Changed
CI workflows (
.github/workflows/)master.yml- Updated Python version for PyO3:PYO3_PYTHON:python3.11→python3.13native-linux-x64-glibc-3.11.node→native-linux-x64-glibc-3.13.nodeApplication images (
packages/cubejs-docker/)Five Dockerfiles updated with identical changes:
dev.Dockerfilelatest.Dockerfile(no JDK dependency)latest-debian-jdk.Dockerfilelocal.Dockerfile(no JDK dependency)testing-drivers.DockerfileChanges:
node:22.22.0-bookworm-slim→node:22.22.0-trixie-slimpython3.11/libpython3.11-dev→python3.13/libpython3.13-devopenjdk-17-jdk-headless/openjdk-17-jre-headless→openjdk-21-jdk-headless/openjdk-21-jre-headless(where applicable)CubeStore images (
rust/cubestore/)Dockerfile- Runtime stage only:debian:bookworm-slim→debian:trixie-slimcubejs/rust-builder:bookworm-llvm-18) intentionally unchanged until new builder image is publishedbuilder.Dockerfile- Security improvements and Trixie migration:RUST_TAG:bookworm-slim→trixie-slim(via1-slim-trixie)OS_NAME:bookworm→trixieapt.llvm.orgsource (LLVM 18 now in Trixie main repos)apt-key addcommandsoftware-properties-common,wget,gnupg,apt-transport-https(no longer needed)docker-bake.hcl- Added new target:rust-builder-trixietarget forcubejs/rust-builder:trixie-llvm-18bookwormandbullseyetargets preservedSecurity Improvements
CVE-2023-45853 Remediation
Builder Image Hardening
apt.llvm.orgno longer needed (LLVM 18 in Debian Trixie)apt-key add(security risk)software-properties-common,wget,gnupg)Extended Support
Breaking Changes
Python Version
cubejs-backend-native) require testingJava Version (JDK images only)
Deferred Work
The following require follow-up after this PR merges:
1. Publish
cubejs/rust-builder:trixie-llvm-18Build and push the new builder image using the updated
builder.Dockerfile:cd rust/cubestore docker buildx bake rust-builder-trixie --pushThe builder now uses only Debian's official repositories and requires no external apt sources.
2. Update CubeStore Dockerfile builder stage
After publishing the new builder image:
This completes the CVE remediation for all stages (currently only runtime is fixed).
3. Update CI workflow
.github/workflows/rust-cubestore.yml- Update container image:References