Skip to content

Conversation

@KSDaemon
Copy link
Contributor

@KSDaemon KSDaemon commented Jan 6, 2026

  • add tests with user_attributes
  • suport user_attributes in cubePropCtxTranspiler

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.15%. Comparing base (a8e448f) to head (e56eb46).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
.../compiler/transpilers/CubePropContextTranspiler.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10287      +/-   ##
==========================================
- Coverage   55.17%   55.15%   -0.02%     
==========================================
  Files         221      221              
  Lines       17202    17208       +6     
  Branches     3521     3524       +3     
==========================================
  Hits         9491     9491              
- Misses       7216     7222       +6     
  Partials      495      495              
Flag Coverage Δ
cube-backend 55.15% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the feat/user_attributes-snake_case branch from e32382d to e56eb46 Compare January 6, 2026 15:15
@KSDaemon KSDaemon marked this pull request as ready for review January 7, 2026 13:25
@KSDaemon KSDaemon requested a review from a team as a code owner January 7, 2026 13:25
@ovr ovr merged commit 652c7ad into master Jan 22, 2026
70 of 72 checks passed
@ovr ovr deleted the feat/user_attributes-snake_case branch January 22, 2026 15:27
@ovr
Copy link
Member

ovr commented Jan 22, 2026

@KSDaemon Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants