feat: Migrate from rust-s3 fork to official AWS SDK for Rust#10269
Open
stevendotdelahunty wants to merge 1 commit intocube-js:masterfrom
Open
feat: Migrate from rust-s3 fork to official AWS SDK for Rust#10269stevendotdelahunty wants to merge 1 commit intocube-js:masterfrom
stevendotdelahunty wants to merge 1 commit intocube-js:masterfrom
Conversation
- Replace rust-s3 fork dependency with aws-config and aws-sdk-s3 - Refactor S3RemoteFs to use AWS SDK client instead of Bucket wrapper - Remove manual credential refresh loop - AWS SDK handles automatically - Update all S3 operations: put_object, get_object, delete_object, list_objects_v2 - Simplify credential chain by leveraging AWS SDK's built-in providers - No breaking changes to RemoteFs and ExtendedRemoteFs interfaces Benefits: - Removes fork maintenance burden - Better automatic credential handling - Cleaner, more maintainable code - Uses officially maintained library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits:
Check List