Skip to content

Comments

fix(css): override drawer body height for active recordings page analysis report#233

Open
aptmac wants to merge 1 commit intocryostatio:mainfrom
aptmac:fix-analysis-css
Open

fix(css): override drawer body height for active recordings page analysis report#233
aptmac wants to merge 1 commit intocryostatio:mainfrom
aptmac:fix-analysis-css

Conversation

@aptmac
Copy link
Member

@aptmac aptmac commented May 14, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Description of the change:

Similar to #123, there is a css rule from the overrides in openshift/console that messes with the layout in the analysis portion of the drawer on the Active Recordings page.

Motivation for the change:

To better align the styling of the console plugin to cryostat web.

Before (Cryostat web vs. Console plugin):
Screenshot from 2025-05-13 13-54-52

After (Console plugin):
Screenshot from 2025-05-14 15-35-33

@aptmac aptmac requested a review from a team as a code owner May 14, 2025 19:39
@mergify mergify bot added the safe-to-test label May 14, 2025
@andrewazores
Copy link
Member

I wonder actually if Patternfly has any design guidelines around this. My sense is that having the empty state and call-to-action at the the top is better because it's closer to the Analyze toolbar button that pulls out the panel, as well as the x that closes it, so this minimizes the amount of cursor movement the user has to do. But visually, maybe having it centered in the panel feels more balanced and pleasing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants