fix(css): override drawer body height for active recordings page analysis report#233
Open
aptmac wants to merge 1 commit intocryostatio:mainfrom
Open
fix(css): override drawer body height for active recordings page analysis report#233aptmac wants to merge 1 commit intocryostatio:mainfrom
aptmac wants to merge 1 commit intocryostatio:mainfrom
Conversation
Member
|
I wonder actually if Patternfly has any design guidelines around this. My sense is that having the empty state and call-to-action at the the top is better because it's closer to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainDescription of the change:
Similar to #123, there is a css rule from the overrides in openshift/console that messes with the layout in the analysis portion of the drawer on the Active Recordings page.
Motivation for the change:
To better align the styling of the console plugin to cryostat web.
Before (Cryostat web vs. Console plugin):

After (Console plugin):
