Skip to content

fix: FrankenPHP build args #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henderkes merged 1 commit into from
Mar 10, 2026
+1 −1
Merged

fix: FrankenPHP build args #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SPC/builder/unix/UnixBuilderBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,8 @@ protected function buildFrankenphp(): void
'XCADDY_GO_BUILD_FLAGS' => '-buildmode=pie ' .
'-ldflags \"-linkmode=external ' . $extLdFlags . ' ' .
'-X \'github.com/caddyserver/caddy/v2/modules/caddyhttp.ServerHeader=FrankenPHP Caddy\' ' .
'-X \'github.com/caddyserver/caddy/v2.CustomBinaryName=frankenphp\' ' .
'-X \'github.com/caddyserver/caddy/v2.CustomVersion=FrankenPHP ' .
'-X \'github.com/caddyserver/caddy/v2.CustomBinaryName=frankenphp ' .
"v{$frankenPhpVersion} PHP {$libphpVersion} Caddy'\\\" " .
"-tags={$muslTags}nobadger,nomysql,nopgx{$nobrotli}{$nowatcher}",
Comment on lines 457 to 463
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: there doesn’t appear to be an automated test asserting the exact formatting of the XCADDY_GO_BUILD_FLAGS string for FrankenPHP (e.g., that CustomBinaryName and CustomVersion are separate -X entries and properly quoted). This area regressed once (#1056); extracting the ldflags construction into a helper and adding a unit test for the resulting env string would help prevent future quoting/concatenation mistakes.

Copilot uses AI. Check for mistakes.
'LD_LIBRARY_PATH' => BUILD_LIB_PATH,
Expand Down
Loading