Add URL query param support for verify_ssl#497
Conversation
amotl
left a comment
There was a problem hiding this comment.
Thank you for the excellent contribution. Lgtm, but let me also add @mfussenegger for an additional review.
|
I hadn't seen #482 |
|
we don't need both. @amotl wdyt? |
|
Hi. I think it is more important for drivers, where you can't define any special flags. However, it is also convenient to be able to use the same style across environments, possibly making the handling easier for scripting purposes. I think GH-482 was written down after a conversation with @WalBeh coming from such spirits. Maybe he can drop a few words about his ambitions? |
Not sure why - using a driver API and invoking the crash CLI is pretty different. Imho the PR isn't needed - more downsides to it due to the additional complexity, both in code but also from a UI perspective for users. |
|
Thanks. @WalBeh: Could you elaborate why this was on your wishlist? Maybe it was a misunderstanding: In this case you can blame that on me. |
Summary of the changes / Why this is an improvement
Adds support for
?verify_ssl=<bool>in the host URL passed to--hosts.The cli flag
--verify-sslcontinues to take precedence over the URL param.Checklist