feat: add version incompatability check & modal#103
Draft
CrabNejonas wants to merge 7 commits intomainfrom
Draft
feat: add version incompatability check & modal#103CrabNejonas wants to merge 7 commits intomainfrom
CrabNejonas wants to merge 7 commits intomainfrom
Conversation
This checks the instrumentations version in the frontend to make sure its version isn't too outdated (the compat behaviour here is very rudimentary) and pop up a modal instructing the user to update the rust crate. resolves DR-623
CrabNejonas
requested review from
atila-crabnebula,
david-crabnebula,
johann-crabnebula,
lucasfernog-crabnebula and
tejas-crabnebula
as code owners
DR-623 Devtools Version Compatibility
We are going to provide a way for people to be informed in the devtools console about the results of Tauri Info, which informs the user if their dependencies are up to date. But what if their tracing-plugin isn't up to date? When there is a compatibility mismatch, we need to have a strategy to:
|
tejas-crabnebula
approved these changes
Nov 23, 2023
Contributor
tejas-crabnebula
left a comment
tejas-crabnebula
left a comment
There was a problem hiding this comment.
TS looks good to me.
Contributor
Author
|
Lets move this to post MVP and discuss how we properly set incompatible versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks the instrumentations version in the frontend to make sure its version isn't too outdated (the compat behaviour here is very rudimentary) and pop up a modal instructing the user to update the rust crate.
resolves DR-623