-
Notifications
You must be signed in to change notification settings - Fork 7
Use 256 bit addition and subtraction for 128-bit decimals to avoid loss of precision #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice one and nice find, Matt. It's amazing how some of the function tests and awesome client tests really find edge cases |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1288 +/- ##
=========================================
- Coverage 99.0% 98.9% -0.0%
=========================================
Files 269 270 +1
Lines 17856 17956 +100
Branches 1985 1998 +13
=========================================
+ Hits 17661 17742 +81
- Misses 195 214 +19
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Closes: #1287