NCO-61: Update async analytics API to current spec#56
Merged
davidkelly merged 7 commits intomasterfrom Apr 11, 2026
Merged
Conversation
Collaborator
davidkelly
commented
Apr 9, 2026
davidkelly
commented
- Refactor async query types for spec compliance:
- Replace QueryStatus and QueryHandleResults with QueryResultHandle
- Remove handle serialization logic
- Adopt fluent builder options (FetchResultHandleOptions, etc.)
- Drop RequestTimeout, ResultTTL, and Deserializer from start options
- Add Scope.StartQueryAsync() to support context-mapped async queries
- Map 404s to QueryNotFoundException on fetches, and treat as success for cancel and discard operations
- Update unit and func tests for options, 404s, and end-to-end flows
* Refactor async query types for spec compliance: * Replace QueryStatus and QueryHandleResults with QueryResultHandle * Remove handle serialization logic * Adopt fluent builder options (FetchResultHandleOptions, etc.) * Drop RequestTimeout, ResultTTL, and Deserializer from start options * Add Scope.StartQueryAsync() to support context-mapped async queries * Map 404s to QueryNotFoundException on fetches, and treat as success for cancel and discard operations * Update unit and func tests for options, 404s, and end-to-end flows
davidkelly
requested review from
emilienbev and
jeffrymorris
and removed request for
emilienbev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.