Added inverted scroll direction for StackScrollTool#1535
Open
christianmol wants to merge 2 commits intocornerstonejs:masterfrom
Open
Added inverted scroll direction for StackScrollTool#1535christianmol wants to merge 2 commits intocornerstonejs:masterfrom
christianmol wants to merge 2 commits intocornerstonejs:masterfrom
Conversation
added 2 commits
March 15, 2023 11:39
…he opposite direction. Allows the StackScrollTool to be inverted in scroll direction. If used in combination with the scroll wheel tool that already has an invert option, this tool would not follow the same direction, resulting in incoherent behaviour.
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
=======================================
Coverage 21.70% 21.71%
=======================================
Files 287 287
Lines 10137 10138 +1
Branches 2081 2082 +1
=======================================
+ Hits 2200 2201 +1
Misses 6750 6750
Partials 1187 1187
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Added an option for inverting the scroll direction of the StackScrollTool
What is the current behavior? (You can also link to an open issue here)
StackScrollTool can only scroll in one direction.
What is the new behavior (if this is a feature change)?
By setting the invert option to true, the tool now scrolls the oposite way, like what is possible with the StackScrollWheelTool
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: