Fix compatibility with latest CIDER's cider-repls API#21
Open
gveres wants to merge 1 commit intocorgi-emacs:mainfrom
Open
Fix compatibility with latest CIDER's cider-repls API#21gveres wants to merge 1 commit intocorgi-emacs:mainfrom
gveres wants to merge 1 commit intocorgi-emacs:mainfrom
Conversation
CIDER updated cider-repls to accept a third optional parameter 'required-ops' for filtering REPLs by supported nREPL operations. The corgi/around-cider-repls advice function only accepted 2 optional parameters, causing an arity mismatch error. Changes: - Updated corgi/around-cider-repls signature to accept required-ops - Added filtering logic to support operation-based REPL filtering - Maintains backward compatibility when required-ops is nil Fixes: wrong-number-of-arguments (1 . 3) 4 error when evaluating Clojure expressions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compatibility issue with the latest version of CIDER where
cider-replsAPI signature changed to include a third optional parameter.Problem
CIDER updated
cider-replsfunction signature from:to:
This caused
corgi/around-cider-replsadvice to fail with:Solution
corgi/around-cider-replsto accept the newrequired-opsparameterrequired-opsis nilTesting
🤖 Generated with Claude Code