dbus: allow multiple calls for the same unit to *Unit #496
+51
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haircommander
force-pushed
the
dbus-reentrant
branch
from
c963247 to
cf0dab7
Compare
Member
|
lgtm |
Contributor
Author
|
@kolyshkin PTAL |
haircommander
added a commit
to haircommander/kubernetes
that referenced
this pull request
Jan 9, 2026
Signed-off-by: Peter Hunt <[email protected]>
kolyshkin
requested changes
Jan 12, 2026
Collaborator
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
Left a few comments.
Also, if you can briefly describe the whole issue in the commit message that'd be awesome (in the ideal world I want to know why we're changing the code just by looking at git log or git show).
haircommander
force-pushed
the
dbus-reentrant
branch
from
cf0dab7 to
be3f615
Compare
Contributor
Author
|
updated as suggested! |
haircommander
force-pushed
the
dbus-reentrant
branch
from
be3f615 to
8b4f566
Compare
kolyshkin
approved these changes
Jan 13, 2026
As well as add a test to prove StopUnit is reentrant There are cases that multiple StopUnits may be called for the same job. For instance, in kubernetes, the Kubelet does so in some cases, when it races against itself to delete a pod. Instead of fixing in the caller, this can be worked around in this library. Instead of losing track of an old job if a new StopUnit is called for the same job, we can just track multiple jobs, and signal to multiple channels when the job finishes. see kubernetes/kubernetes#135826 and kubernetes/kubernetes#135825 for some more context Signed-off-by: Peter Hunt <[email protected]>
Luap99
force-pushed
the
dbus-reentrant
branch
from
8b4f566 to
83b9e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as add a test to prove StopUnit is reentrant
Alternative to kubernetes/kubernetes#135826
should fix kubernetes/kubernetes#135825 (need to do some testing to double check)
credit to @rphillips for the idea and original piece of code