opencode: add signing-key-rotation and release-prep skills#1735
Open
prestist wants to merge 1 commit intocoreos:mainfrom
Open
opencode: add signing-key-rotation and release-prep skills#1735prestist wants to merge 1 commit intocoreos:mainfrom
prestist wants to merge 1 commit intocoreos:mainfrom
Conversation
Add two OpenCode automation skills: - signing-key-rotation: automates adding/dropping Fedora signing keys in src/signing-keys.asc and docs/release-notes.md - release-prep: automates pre-release PR preparation including dependency updates and release notes drafting
There was a problem hiding this comment.
Code Review
This pull request introduces two new automation skills for the coreos-installer project: release-prep and signing-key-rotation. The release-prep skill automates dependency updates and release notes generation, while the signing-key-rotation skill handles the addition and removal of Fedora GPG keys. Feedback was provided regarding a logic error in the release notes header update process and the restrictive version incrementing logic. Additionally, improvements were suggested for the signing key rotation to use raw download URLs and to implement more robust verification checks for the key file state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two OpenCode automation skills: