-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Allow OAuth registration when signup is disabled and enforce OAuth-on… #8043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Allow OAuth registration when signup is disabled and enforce OAuth-on… #8043
Conversation
|
@ShadowArcanist could you please share the reason the PR was closed? I’d like to understand and improve for future contributions. |
|
Closed because https://github.com/coollabsio/coolify/blob/v4.x/CONTRIBUTING.md and PR template is ignored |
|
@ShadowArcanist thanks for taking a look earlier. I’ve addressed the missing requirements (PR description clarity, testing notes, and screenshots) and understand the guidelines better now. Would you be open to reopening this PR so I can convert it to a draft for review, or would you prefer I open a fresh one? |
|
Reopened, you can work on this PR instead of opening new one |
|
OK @ShadowArcanist thank you so much for the opportunity |
|
Thanks @ShadowArcanist, really appreciate it 🙏 |
|
I briefly closed/reopened the PR while restoring the branch, but everything is back in place now. |
|
Much better than before, please follow our PR template (example: #8022) Here is the template: ### Changes
<!-- Describe your changes clearly and concisely. What was fixed, added, or updated? -->
<!-- PRs containing vague or generic AI-generated "changes" will be closed without review. -->
>
>
### Issue
<!-- Provide the link to the issue this PR addresses (e.g., "Resolves #123") -->
> -
### Category
<!-- You must choose **one** option and remove the other. Failure to select an option, selecting multiple options, or selecting the incorrect option will result in the PR being closed immediately without review. -->
> - [x] Bug fix
> - [x] New feature
> - [x] Adding new one click service
> - [x] Fixing or updating existing one click service
### Screenshots or Video (if applicable)
<!-- Include screenshots or a short video if it helps illustrate the changes. Remove this section if not applicable. -->
<!-- If this PR claims a bounty, a screen recording is mandatory. Any bounty-claiming PR submitted without a screen recording will be closed immediately without review. -->
### AI Usage
<!-- You must choose **one** option and remove the other. Failure to select an option, selecting both options, or selecting the incorrect option will result in the PR being closed immediately without review. -->
<!-- This refers to all parts of the PR, including the code, tests, and documentation. -->
> - [x] AI is used in the process of creating this PR
> - [x] AI is NOT used in the process of creating this PR
### Steps to Test
<!-- PRs without a clear step-by-step guide to test the changes will be closed without review. Including generic AI-fluff steps will also be closed without review. Be explicit and detailed. -->
<!-- Make sure each step is actionable and verifiable. Avoid vague statements like "check if it works." -->
> - Step 1 – what to do first
> - Step 2 – next action
> - Step 3 – expected outcome
> - Step 4 – additional checks (if any)
### Contributor Agreement
<!-- This section must not be removed. PRs that do not include the exact contributor agreement will not be reviewed and will be closed. -->
> [!IMPORTANT]
> - [x] I have read and understood the [contributor guidelines](https://github.com/coollabsio/coolify/blob/v4.x/CONTRIBUTING.md). If I have failed to follow any guideline, I understand that this PR may be closed without review.
> - [x] I have tested the changes thoroughly and am confident that they will work as expected without issues when the maintainer tests them
|
|
@ShadowArcanist the pr description now follows the provided template... Please let me know if you need any more changes |
Looks alot better now. I am not a core maintainer and my knowledge with the codebase is minimal so we have to wait for the core developers to review this PR. They will review PRs when they have time. Note: I am just doing some ground work to make the PRs easy for review. |
|
Thanks @ShadowArcanist, really appreciate you taking the time to help clean this up and make it easier to review 🙏 |
90219e5 to
6707bbd
Compare
|
Hi @andrasbacsai 👋 @peaklabs-dev |
6707bbd to
3437d3b
Compare
3437d3b to
f53b082
Compare
|
@ShadowArcanist it's been 5 days and still no update |
|
@samuel-asleep Please have some patience. Coolify has over 70 open PRs right now. Your PR is also very large and introduces a lot of changes which makes it more time intensive to review. There are currently other things such as bugfixes that have higher priority then a new feature like this. As the Coolify team is preparing a stable release for v4. If you have questions about your PR feel free to join the Discord Server and we can have a chat about it. |
|
Hi @samuel-asleep! 👋 It appears to us that you are adding a new feature to Coolify. Coolify Docs Repository: https://github.com/coollabsio/coolify-docs |
Changes
This PR allows OAuth-based user registration independently of general self-registration and enables enforcing OAuth-only authentication for users created via OAuth providers.
Specifically:
Issue
Category
Screenshots or Video (if applicable)
1. Registration page before settings change (registration enabled)

2. OAuth provider configuration (GitHub enabled with placeholder credentials)

3. General registration disabled in Advanced settings

4. Registration page after settings change (OAuth login still available)

AI Usage
Steps to Test
Contributor Agreement
Important