Skip to content

Conversation

@samuel-asleep
Copy link

@samuel-asleep samuel-asleep commented Jan 26, 2026

Changes

This PR allows OAuth-based user registration independently of general self-registration and enables enforcing OAuth-only authentication for users created via OAuth providers.

Specifically:

  • OAuth users can be created even when general self-registration is disabled.
  • OAuth registration is controlled via a new instance-level setting.
  • Users created through OAuth can be restricted from using password-based login and password reset.
  • Existing users are not affected.

Issue


Category

  • New feature

Screenshots or Video (if applicable)

1. Registration page before settings change (registration enabled)
Registration page before settings change

2. OAuth provider configuration (GitHub enabled with placeholder credentials)
OAuth provider configuration

3. General registration disabled in Advanced settings
General registration disabled

4. Registration page after settings change (OAuth login still available)
Registration page after settings change


AI Usage

  • AI is used in the process of creating this PR

Steps to Test

  • Step 1 – Go to Settings → Advanced and disable Registration Allowed
  • Step 2 – Go to Settings → OAuth and enable GitHub OAuth with placeholder credentials
  • Step 3 – Save the settings
  • Step 4 – Open the login page and verify password-based registration is disabled
  • Step 5 – Verify the Login with GitHub option is still visible and available
  • Step 6 – Log in as an existing user and confirm password login still works

Contributor Agreement

Important

  • I have read and understood the contributor guidelines. If I have failed to follow any guideline, I understand that this PR may be closed without review.
  • I have tested the changes thoroughly and am confident that they will work as expected without issues when the maintainer tests them.

@algora-pbc algora-pbc bot added the 🙋 Bounty claim Issues or PRs that have a Bounty ready to be claimed. label Jan 26, 2026
@github-actions github-actions bot removed the 🙋 Bounty claim Issues or PRs that have a Bounty ready to be claimed. label Jan 26, 2026
@samuel-asleep
Copy link
Author

@ShadowArcanist could you please share the reason the PR was closed? I’d like to understand and improve for future contributions.

@ShadowArcanist
Copy link
Member

Closed because https://github.com/coollabsio/coolify/blob/v4.x/CONTRIBUTING.md and PR template is ignored

@samuel-asleep
Copy link
Author

@ShadowArcanist thanks for taking a look earlier. I’ve addressed the missing requirements (PR description clarity, testing notes, and screenshots) and understand the guidelines better now. Would you be open to reopening this PR so I can convert it to a draft for review, or would you prefer I open a fresh one?

@ShadowArcanist
Copy link
Member

Reopened, you can work on this PR instead of opening new one

@samuel-asleep samuel-asleep marked this pull request as draft January 26, 2026 13:47
@samuel-asleep
Copy link
Author

OK @ShadowArcanist thank you so much for the opportunity

@samuel-asleep samuel-asleep marked this pull request as ready for review January 26, 2026 15:57
@samuel-asleep
Copy link
Author

Thanks @ShadowArcanist, really appreciate it 🙏
I’ve updated the PR with screenshots and details and marked it ready for review.
Happy to make any changes if needed.

@samuel-asleep samuel-asleep deleted the enhance-self-registration-oauth branch January 26, 2026 16:02
@samuel-asleep samuel-asleep restored the enhance-self-registration-oauth branch January 26, 2026 16:06
@samuel-asleep samuel-asleep reopened this Jan 26, 2026
@samuel-asleep
Copy link
Author

I briefly closed/reopened the PR while restoring the branch, but everything is back in place now.
Thanks again — ready for review whenever you have time.

@ShadowArcanist
Copy link
Member

Much better than before, please follow our PR template (example: #8022)

Here is the template:

### Changes
<!-- Describe your changes clearly and concisely. What was fixed, added, or updated? -->
<!-- PRs containing vague or generic AI-generated "changes" will be closed without review. -->
> 
> 


### Issue 
<!-- Provide the link to the issue this PR addresses (e.g., "Resolves #123") -->
> - 


### Category
<!--  You must choose **one** option and remove the other. Failure to select an option, selecting multiple options, or selecting the incorrect option will result in the PR being closed immediately without review.  -->
> - [x] Bug fix
> - [x] New feature
> - [x] Adding new one click service
> - [x] Fixing or updating existing one click service


### Screenshots or Video (if applicable) 
<!-- Include screenshots or a short video if it helps illustrate the changes. Remove this section if not applicable. -->
<!-- If this PR claims a bounty, a screen recording is mandatory. Any bounty-claiming PR submitted without a screen recording will be closed immediately without review. -->


### AI Usage
<!--  You must choose **one** option and remove the other. Failure to select an option, selecting both options, or selecting the incorrect option will result in the PR being closed immediately without review.  -->
<!--  This refers to all parts of the PR, including the code, tests, and documentation. -->
> - [x] AI is used in the process of creating this PR
> - [x] AI is NOT used in the process of creating this PR


### Steps to Test
<!-- PRs without a clear step-by-step guide to test the changes will be closed without review. Including generic AI-fluff steps will also be closed without review. Be explicit and detailed. -->
<!-- Make sure each step is actionable and verifiable. Avoid vague statements like "check if it works." -->
> - Step 1 – what to do first
> - Step 2 – next action
> - Step 3 – expected outcome
> - Step 4 – additional checks (if any)


### Contributor Agreement
<!-- This section must not be removed. PRs that do not include the exact contributor agreement will not be reviewed and will be closed. -->
> [!IMPORTANT]
 > - [x] I have read and understood the [contributor guidelines](https://github.com/coollabsio/coolify/blob/v4.x/CONTRIBUTING.md). If I have failed to follow any guideline, I understand that this PR may be closed without review.
 > - [x] I have tested the changes thoroughly and am confident that they will work as expected without issues when the maintainer tests them
 

@ShadowArcanist ShadowArcanist added 🙋 Bounty claim Issues or PRs that have a Bounty ready to be claimed. 💤 Waiting for changes PRs awaiting changes from the author. labels Jan 26, 2026
@samuel-asleep
Copy link
Author

@ShadowArcanist the pr description now follows the provided template... Please let me know if you need any more changes

@ShadowArcanist ShadowArcanist removed the 💤 Waiting for changes PRs awaiting changes from the author. label Jan 26, 2026
@ShadowArcanist
Copy link
Member

@ShadowArcanist the pr description now follows the provided template... Please let me know if you need any more changes

Looks alot better now. I am not a core maintainer and my knowledge with the codebase is minimal so we have to wait for the core developers to review this PR. They will review PRs when they have time.

Note: I am just doing some ground work to make the PRs easy for review.

@samuel-asleep
Copy link
Author

Thanks @ShadowArcanist, really appreciate you taking the time to help clean this up and make it easier to review 🙏
I’ll wait for the core maintainers’ review. Happy to answer questions or make adjustments if anything comes up.

@samuel-asleep samuel-asleep force-pushed the enhance-self-registration-oauth branch from 90219e5 to 6707bbd Compare January 27, 2026 21:13
@samuel-asleep
Copy link
Author

samuel-asleep commented Jan 27, 2026

Hi @andrasbacsai 👋 @peaklabs-dev
If you or any other maintainer has time, I’d really appreciate a review on this PR.
Happy to make any changes if needed — thanks!

@samuel-asleep samuel-asleep force-pushed the enhance-self-registration-oauth branch from 6707bbd to 3437d3b Compare January 28, 2026 14:28
@samuel-asleep samuel-asleep force-pushed the enhance-self-registration-oauth branch from 3437d3b to f53b082 Compare January 31, 2026 02:30
@samuel-asleep
Copy link
Author

@ShadowArcanist it's been 5 days and still no update

@Cinzya
Copy link
Member

Cinzya commented Jan 31, 2026

@samuel-asleep Please have some patience. Coolify has over 70 open PRs right now. Your PR is also very large and introduces a lot of changes which makes it more time intensive to review. There are currently other things such as bugfixes that have higher priority then a new feature like this. As the Coolify team is preparing a stable release for v4.

If you have questions about your PR feel free to join the Discord Server and we can have a chat about it.

@Cinzya Cinzya added the 🛠️ Feature Issues requesting a new feature. label Jan 31, 2026
@github-actions
Copy link
Contributor

Hi @samuel-asleep! 👋

It appears to us that you are adding a new feature to Coolify.
We kindly ask you to also update the Coolify Documentation to include information about this new feature.
This will help ensure that our documentation remains accurate and up-to-date for all users.

Coolify Docs Repository: https://github.com/coollabsio/coolify-docs
How to Contribute to the Docs: https://coolify.io/docs/get-started/contribute/documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Bounty claim Issues or PRs that have a Bounty ready to be claimed. 🛠️ Feature Issues requesting a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants