fixed the Sentinel bug #7421
fixed the Sentinel bug #7421
Conversation
|
Hey @sanjana2505006 the target branch should be |
ShadowArcanist
added
the
💤 Waiting for changes
|
@ShadowArcanist okay, let me fix this! |
| $versions = get_versions_data(); | ||
|
|
||
| return data_get($versions, 'coolify.sentinel.version'); | ||
| return data_get($versions, 'coolify.sentinel.version', '0.0.0'); |
There was a problem hiding this comment.
Sentinel doesn't depend on a specific Coolify version. This way, people would never be able to receive the latest version until they update Coolify. I think it would be better if we keep the network request, and only read the local version if that request fails as the "new fallback".
There was a problem hiding this comment.
@Cinzya in the new commit,
0.0.0 is just a final safety fallback:
The value 0.0.0 is only used if both the network fetch and the local file fail (which is extremely unlikely).
|
Hello @ShadowArcanist @Cinzya, |
4 participants
This pull request fixes the issue described in #7420.
Fix: Sentinel failing to start due to version 0.0.0
Sentinel was using the fallback version 0.0.0 when the external version check failed, causing the container to pull a non-existent image.
I updated get_latest_sentinel_version in bootstrap/helpers/shared.php to read the version from the local versions.json instead of relying on a network request.
This ensures Sentinel always uses a valid version and starts correctly, even offline.