Open
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@milroy this is ready to test when you have bandwidth, which I don't think needs to be soon. For context, we want to restore this PR in the updated (v2) usernetes setup. The reason is to hopefully avoid this setting:
Ping me if/when you want to test it out. I suspect we need to bring up two nodes and test networking, test the newer release, and then debug why the quay.io (image they provide) has an ssl error (hence using an image I pushed to our registry). When it is working for our setup we will want to redo the work on the master branch (that mirrors what upstream has) and open a pull request. Maybe you can do that this time, because I haven't had luck with Akihiro accepting any of my PRs. After that I'd like to fully test and merge #2 so we don't fall too behind.
No urgency on any of this - just putting it here so it's around as a starting template when needed.