Skip to content

SECURITY.md: Use GitHub Security Advisory for reports#462

Merged
rhatdan merged 1 commit intocontainers:mainfrom
lsm5:security-md-re-refresh
May 5, 2026
Merged

SECURITY.md: Use GitHub Security Advisory for reports#462
rhatdan merged 1 commit intocontainers:mainfrom
lsm5:security-md-re-refresh

Conversation

@lsm5
Copy link
Copy Markdown
Member

@lsm5 lsm5 commented May 4, 2026

Podman and other CNCF projects will soon be moving to another GitHub org so we can't continue to depend on SECURITY.md in container-libs.

Copied from containers/ramalama with modifications.

Fixes: #461

Summary by Sourcery

Documentation:

  • Add project-specific SECURITY.md instructions directing reporters to use GitHub Security Advisories for private vulnerability disclosure.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 4, 2026

Reviewer's Guide

Replaces the old reference-based security policy with a self-contained SECURITY.md that directs reporters to use GitHub Security Advisories for private vulnerability disclosure, including concrete reporting steps and expectations.

File-Level Changes

Change Details Files
Replace the previous link-based security policy with a detailed, project-specific vulnerability reporting process using GitHub Security Advisories.
  • Remove the reference to the shared container-libs SECURITY.md policy.
  • Add a 'Reporting Security Vulnerabilities' section that instructs reporters to use the repository's GitHub Security Advisory page.
  • Explicitly discourage public disclosure via issues, mailing lists, or Matrix.
  • Document required report contents such as description, reproduction steps, impact, and suggested fixes.
  • Describe the expected triage process including acknowledgment timelines, progress updates, and researcher credit.
SECURITY.md

Assessment against linked issues

Issue Objective Addressed Explanation
#461 Make SECURITY.md a standalone document for container-selinux instead of relying on the shared Containers Projects security policy.
#461 Switch to and document GitHub's native security vulnerability reporting (Security Advisory) as the mechanism for reporting issues in container-selinux.

Possibly linked issues

  • SECURITY.md refresh #461: PR updates SECURITY.md to use GitHub Security Advisory, exactly implementing the issue’s requested security reporting change.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented May 4, 2026

@containers/container-selinux-maintainers PTAL

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SECURITY.md file to include a comprehensive policy for reporting security vulnerabilities, replacing the previous external link. The new content details the reporting process via GitHub Security Advisories and outlines the expected response from maintainers. Feedback focuses on improving the clarity of the instructions by removing redundant warnings and ensuring consistent punctuation across the document.

Comment thread SECURITY.md Outdated
Comment thread SECURITY.md Outdated
@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented May 4, 2026

NOTE: People without github accounts would find it hard to report issues, but then again, we don't receive frequent reports for container-selinux anyway, so I assume that possiblity to be minuscule.

@lsm5 lsm5 force-pushed the security-md-re-refresh branch from 953c027 to 9c778bd Compare May 4, 2026 19:52
@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

Podman and other CNCF projects will soon be moving to another GitHub org
so we can't continue to depend on SECURITY.md in container-libs.

Copied from containers/ramalama with modifications.

Fixes: containers#461

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the security-md-re-refresh branch from a7fc40f to 5b2d20d Compare May 4, 2026 19:53
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented May 5, 2026

LGTM

@rhatdan rhatdan merged commit add9f4a into containers:main May 5, 2026
29 of 32 checks passed
@lsm5 lsm5 deleted the security-md-re-refresh branch May 5, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SECURITY.md refresh

2 participants