Draft
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
lsm5
force-pushed
the
podman6-no-cni
branch
4 times, most recently
from
32e105a to
79be198
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
Signed-off-by: Lokesh Mandvekar <[email protected]>
Buildah no longer uses CNI for networking, so remove CNI spec version and libcni version from the version command output, build-time linker flags, and RPM spec. Also drop the FreeBSD CNI build tag from the Makefile since netavark is now the only supported network backend.
Remove CNIPluginPath and CNIConfigDir fields from Builder, BuilderInfo, BuilderOptions, RunOptions, and BuildOptions structs. Remove --cni-config-dir and --cni-plugin-path CLI flags. Simplify getNetworkInterface() to no longer accept CNI-specific parameters since netavark is now the only supported network backend.
Remove the docs/cni-examples/ directory, CNI installation section from install.md, and CNI fields from version man page. Remove the "from cni config test" from tests/from.bats and clean up --cni-config-dir usage from tests/namespaces.bats. Update comments that referenced CNI to use generic network terminology.
Remove the github.com/containernetworking/cni module from go.mod, go.sum, and vendor since it is no longer used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Removes CNI for podman6
How to verify it
check if any CNI stuff still exists
Which issue(s) this PR fixes:
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?