Skip to content

fix host-device causes ip leak after reboot node #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hangzhouwanjun wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix host-device causes ip leak after reboot node #1197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a612829
Update host-device.go
hangzhouwanjun Aug 7, 2025
12be742
Update host-device.go
hangzhouwanjun Aug 7, 2025
e515107
host-device causes ip leak after reboot node
hangzhouwanjun Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions plugins/main/host-device/host-device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,14 @@
if err != nil {
return err
}

// reboot node there no containerNs, first ipam del avoid ip leak
if cfg.IPAM.Type != "" {
if err := ipam.ExecDel(cfg.IPAM.Type, args.StdinData); err != nil {
return err
}
}

Check failure on line 221 in plugins/main/host-device/host-device.go

View workflow job for this annotation

GitHub Actions / Lint 

File is not properly formatted (gci)
Copy link
Contributor

@s1061123 s1061123 Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions told that there is some golang format error. Could you please take a look into it and fix it?

if args.Netns == "" {
return nil
}
Expand All @@ -220,12 +228,6 @@
}
defer containerNs.Close()

if cfg.IPAM.Type != "" {
if err := ipam.ExecDel(cfg.IPAM.Type, args.StdinData); err != nil {
return err
}
}

if !cfg.DPDKMode {
if err := moveLinkOut(containerNs, args.IfName); err != nil {
return err
Expand Down
Loading