This repository was archived by the owner on Feb 20, 2024. It is now read-only.
rename schema registry ports + add early failure condition#593
Open
Daniel Quackenbush (danquack) wants to merge 1 commit intoconfluentinc:masterfrom
Open
rename schema registry ports + add early failure condition#593Daniel Quackenbush (danquack) wants to merge 1 commit intoconfluentinc:masterfrom
Daniel Quackenbush (danquack) wants to merge 1 commit intoconfluentinc:masterfrom
Conversation
Daniel Quackenbush (danquack)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When installing the helm chart, I ran into a startup failure due to the environment variable
SCHEMA_REGISTRY_PORTbeing set. To avoid this, I am proposing changing all named ports and perform a validation check to on the service to ensure that it is not being name schema-registry, which according to the docs, sets the service name as an active environment. This causes an exit status on the app confluentinc/schema-registry#689.I also set the named port to be http for any future iterations. But that's an opinionated portion.
How was this patch tested?
I set fullnameOverride in the values file and verified it errored.