Rework update-news & banner into new pre-commit hook (index-blog)#234
Draft
kenodegard wants to merge 11 commits intoconda:mainfrom
Draft
Rework update-news & banner into new pre-commit hook (index-blog)#234kenodegard wants to merge 11 commits intoconda:mainfrom
update-news & banner into new pre-commit hook (index-blog)#234kenodegard wants to merge 11 commits intoconda:mainfrom
Conversation
❌ Deploy Preview for conda-dot-org failed.Built without sensitive environment variables
|
update-news & banner into new pre-commit hook (index-blog)
Contributor
Author
|
pre-commit.ci autofix |
Contributor
Author
|
ugh pre-commit seems to timeout, need to rethink how the dependencies get installed |
Member
|
I like this, were you able to make any progress on the debugging? |
Contributor
|
I was also wondering about this. What about making this part of the website render process? We "only" need a component for the frontpage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently rely on the
npm run update-newsscript (written in Python) to scrape the 5 most recent blog posts.We also have a
npm run bannersscript to generate banners for blog posts.In this PR we seek to combine all of this into one super tool that scrapes the recent blog posts but also checks the frontmatter for correctness (e.g., is
slugandimagedefined).In order to avoid complexities (impossibilities?) of trying to call Node.js from Python within the pre-commit container I opted to convert
update-newsinto a JS script (now calledindex-blog).With this change both of the scripts are still callable via
npm runbut they are also included as a pre-commit hook.learn/orcommunity/, I have added it to the corresponding_sidebar.jsonfile.