Test for missing libraries in legacy variable#19724
Draft
AbrilRBS wants to merge 6 commits intoconan-io:develop2from
Draft
Test for missing libraries in legacy variable#19724AbrilRBS wants to merge 6 commits intoconan-io:develop2from
AbrilRBS wants to merge 6 commits intoconan-io:develop2from
Conversation
memsharded
reviewed
Mar 23, 2026
test/integration/toolchains/cmake/cmakeconfigdeps/test_cmakeconfigdeps.py
Show resolved
Hide resolved
memsharded
reviewed
Mar 23, 2026
test/integration/toolchains/cmake/cmakeconfigdeps/test_cmakeconfigdeps.py
Outdated
Show resolved
Hide resolved
memsharded
approved these changes
Mar 23, 2026
| mypkg_config = tc.load("mypkg-config.cmake") | ||
| assert 'set(mypkg_DEFINITIONS "-DMY_DEFINE;-DMYVAR=1" )' in mypkg_config | ||
|
|
||
| def test_legacy_defines_multiple_components(self): |
Member
There was a problem hiding this comment.
If I understood it correctly, this was already working correctly, but not covered by tests?
The failing test would be the "libraries" test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
developbranch, documenting this one.