abstract toolchain file tip#19602
Merged
memsharded merged 1 commit intoconan-io:develop2from Feb 12, 2026
Merged
Conversation
AbrilRBS
reviewed
Feb 11, 2026
| # https://github.com/conan-io/conan/pull/12034#issuecomment-1253776285 | ||
| vars_tip = " ".join([f"-D{k}={_format_val(v)}" for k, v in cache_variables.items()]) | ||
| tc_tip = f"-DCMAKE_TOOLCHAIN_FILE=<output_folder>/{toolchain_file} " \ | ||
| if "CMAKE_TOOLCHAIN_FILE" not in vars_tip else "" |
Member
There was a problem hiding this comment.
but vars_tip would always be ["-DCMAKE_TOOLCHAIN....] so the CMAKE_TOOLCHAIN_FILE literal would never be contained no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Improve the
-DCMAKE_TOOLCHAIN_FILEtip in CMakeToolchain generator to abstract it to a<output_folder>Docs: Omit
Close #19022