Skip to content

Conversation

@AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Feb 11, 2026

Changelog: TODO
Docs: TODO

Started as a test for replace requires with host_version chains when the user/channel didn't match, see
#19598

@AbrilRBS AbrilRBS changed the title Test for replace_requires that is part of a <host_version> chain Test automatic user/channel in <host_version> Feb 11, 2026
@AbrilRBS AbrilRBS added this to the 2.26.0 milestone Feb 11, 2026
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and could be moved forward

@AbrilRBS AbrilRBS changed the title Test automatic user/channel in <host_version> Automatic user/channel in <host_version> Feb 11, 2026
@AbrilRBS AbrilRBS marked this pull request as ready for review February 11, 2026 15:51
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only a small comment about this case:

                def requirements(self):
                    self.requires("protobuf/1.0@user/channel")
                def build_requirements(self):
                    self.tool_requires("protobuf/<host_version>@user/channel")

Could we raise an error and say something like It's not allowed to use the "@user/channel" when "<host_version>" is declared??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants