Add default #platform revision to repalce_{tool_}requires
#19561
+60
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
AbrilRBS
changed the title
#platform revision to repalce_{tool_}requires
AbrilRBS
commented
Feb 10, 2026
| tc.assert_listed_require({f"dep/1.0#{expected_rev}": "Platform"}, build=is_tool_platform) | ||
|
|
||
| tc.run("install --lockfile=platform.lock", assert_error=True) | ||
| assert "Package 'dep/1.0' not resolved" in tc.out |
Member
Author
There was a problem hiding this comment.
Wondering if this error should use repr_notime() internally to show the revision if available?
Member
There was a problem hiding this comment.
Yes, but maybe unrelated ,so better in another PR?
memsharded
approved these changes
Feb 10, 2026
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
Looking good, but I am still wondering if there is some possible risk of breaking? Something that we could be missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Add default
#platformrevision torepalce_{tool_}requiresDocs: TODO?
For #19548
This will allow to lock on platform requires in lockfiles. Note that users can specify their own revision instead of using the default one, useful if any change to the system requirement changed and reflecting the binary difference is desired