Conversation
compor
left a comment
There was a problem hiding this comment.
Could you add a minimal example that reproduces the issue? You can add it as example04 in the top-level directory.
I plan to write some basic tests and move the examples to form a small test suite.
| COMMAND llc | ||
| ARGS | ||
| -filetype=obj | ||
| -relocation-model=pic |
There was a problem hiding this comment.
I added this flag because the compiler complained in my real project that I needed to recompile with -fPIC.
There was a problem hiding this comment.
I'd rather not have project-specific options hardcoded like this.
This command handles other args and passes them unaltered using ${LLVMIR_ATTACH_UNPARSED_ARGUMENTS}.
Can you please try your project with defining that flag in your CMakeLists.txt?
| endforeach() | ||
|
|
||
| set(FULL_OUT_LLVMIR_FILE "${WORK_DIR}/${TRGT}.o") | ||
| if(SHORT_NAME) |
There was a problem hiding this comment.
Isn't SHORT_NAME still useful for the multiple output files generated by the changes in your PR?
There was a problem hiding this comment.
In my project it worked fine without it, so I assumed that I could just remove it.
There was a problem hiding this comment.
Can you please reintroduce it and check that your project still works?
Just because it's not needed in your configuration doesn't mean that wasn't introduced for a reason initially.
| COMMAND llc | ||
| ARGS | ||
| -filetype=obj | ||
| -relocation-model=pic |
There was a problem hiding this comment.
I'd rather not have project-specific options hardcoded like this.
This command handles other args and passes them unaltered using ${LLVMIR_ATTACH_UNPARSED_ARGUMENTS}.
Can you please try your project with defining that flag in your CMakeLists.txt?
| endforeach() | ||
|
|
||
| set(FULL_OUT_LLVMIR_FILE "${WORK_DIR}/${TRGT}.o") | ||
| if(SHORT_NAME) |
There was a problem hiding this comment.
Can you please reintroduce it and check that your project still works?
Just because it's not needed in your configuration doesn't mean that wasn't introduced for a reason initially.
When the target library is compiled to a static library with the following CMAKE options:
I got the following error message:
The problem is that LLC only supports one input file. This PR fixes this issue by going over each bc file separately.