chore: Deserialize data field of broadcast tx response as hex bytes#1501
Merged
chore: Deserialize data field of broadcast tx response as hex bytes#1501
Conversation
romac
approved these changes
May 5, 2025
Contributor
romac
left a comment
romac
left a comment
There was a problem hiding this comment.
Looks good! I double-checked and CometBFT uses hex encoding for those fields since at least v0.34.x, so all good. Thanks for the fix!
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
Jun 10, 2025
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1500
.changelog/