Closed
Conversation
melekes
reviewed
Apr 10, 2025
.changelog/unreleased/improvements/1499-refactor-duplicate-vote-detection.md
Outdated
Show resolved
Hide resolved
| fn test_successful_verify_malicious_update_header_2() { | ||
| // This test is almost same as the previous one. | ||
| // The only difference is order of the validator set iteration. | ||
| // In this case, the verifier will correctly detect invalid signature. |
Author
There was a problem hiding this comment.
test_successful_verify_malicious_update_header_1 (the existing test) is the other case.
Basically, a malicious validator could only reuse its vote if only it came earlier than the targeted validator in this following loop (test_successful_verify_malicious_update_header_1).
If the targeted validator came earlier in this loop, the verifier will see vote.verified is false and (in)validate the signature (test_successful_verify_malicious_update_header_2).
Author
There was a problem hiding this comment.
check 73dec22 for the changes I made to the existing test to trigger the invalid signature error.
Co-authored-by: Anton Kaliaev <[email protected]>
Author
|
Interesting that other tests started failing 😅 I will take a look at it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a minor refactor to optimize the logic to check for duplicate votes.
.changelog/