Skip to content

fix(tendermint): Fix deserialization from serde_json::Value#1475

Merged
melekes merged 8 commits intocometbft:mainfrom
oblique:fix/issue-1474
Apr 17, 2025
Merged

fix(tendermint): Fix deserialization from serde_json::Value#1475
melekes merged 8 commits intocometbft:mainfrom
oblique:fix/issue-1474

Conversation

@oblique
Copy link
Contributor

@oblique oblique commented Nov 18, 2024

Fixes #1474

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@oblique
Copy link
Contributor Author

oblique commented Nov 18, 2024

Some questions:

  1. CowStr can also be used in any place of tendermint-rs that uses String::deserialize etc. Should I change all of them?
  2. Do you like CowStr or should I just use String?

@romac
Copy link
Contributor

romac commented Dec 11, 2024

Some questions:

  1. CowStr can also be used in any place of tendermint-rs that uses String::deserialize etc. Should I change all of them?

This can be done in a follow-up PR :)

  1. Do you like CowStr or should I just use String?

CowStr is fine!

@romac
Copy link
Contributor

romac commented Dec 11, 2024

Can you please add a changelog entry in the appropriate subdirectory in .changelog/? Then I'll gladly merge this :)

@melekes
Copy link
Collaborator

melekes commented Apr 9, 2025

@oblique hey! Sorry for the delay here. Do you have the capacity to finish this?

Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oblique
Copy link
Contributor Author

oblique commented Apr 10, 2025

@melekes Hey, sorry, I completely forgot about this PR. Thanks for pinging. I added the changelog, I hope it's how you want it.

@melekes
Copy link
Collaborator

melekes commented Apr 10, 2025

@oblique
Copy link
Contributor Author

oblique commented Apr 17, 2025

@melekes fixed all the clippy issues of tendermint-proto and tendermint

@melekes melekes merged commit a38e9f5 into cometbft:main Apr 17, 2025
21 of 22 checks passed
@oblique oblique deleted the fix/issue-1474 branch April 17, 2025 11:24
melekes added a commit to cometbft/cometbft-rs that referenced this pull request Jun 10, 2025
melekes added a commit to cometbft/cometbft-rs that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tendermint::Hash can not be used as a return value when used with jsonrpsee

3 participants