fix(clap): migrate deprecated #[clap(...)] usages to #[arg(...)] and …

[melekes]

…#[command(...)]

Port-of: cometbft/tendermint-rs#1492

[Copilot]

Pull Request Overview

This PR updates deprecated #[clap(...)] attributes to the new #[arg(...)] and #[command(...)] patterns, adjusts a time utility to use the Month enum, and silences lint warnings on some router methods.

• Migrate all #[clap(...)] to #[arg(...)] (and one flatten to #[command(...)])
• Update num_days_in_month to use time::Month and days_in_month
• Add #[allow(dead_code)] to unused router methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
rpc/src/client/transport/router.rs	Silence dead-code lint on two subscription methods
pbt-gen/src/time.rs	Convert raw u8 months to time::Month, call days_in_month
light-client-cli/src/main.rs	Replace #[clap] with #[arg] for flags and one flatten change

Comments suppressed due to low confidence (3)

rpc/src/client/transport/router.rs:94

• [nitpick] Consider removing or documenting this unused add method instead of silencing the lint; it may be dead code or require tests before allowing it.

#[allow(dead_code)]

rpc/src/client/transport/router.rs:109

• [nitpick] This remove_by_query method is marked as dead code; either remove it if unused or add a comment explaining its retention.

#[allow(dead_code)]

pbt-gen/src/time.rs:65

• [nitpick] For consistency, group this import with the other time imports at the top of the module.

use time::Month;