[OPIK-6291] [DOCS] feat: surface PR-level review bodies in /address-github-pr-comments#6536
Merged
Merged
Conversation
…github-pr-comments Update the skill to fetch and triage three distinct feedback categories (inline comments, issue thread comments, PR-level review bodies) so that CHANGES_REQUESTED / COMMENTED reviews with feedback only in the body are no longer silently dropped. Document the quote-reply flow on the issue thread for PR-level reviews (no review thread exists) and the quote-based idempotency check for re-runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Address PR review feedback on Category 3 logic: - Make per-reviewer latest-review selection explicit (sort by submitted_at, one review per reviewer) so older reviews can't stay pending after a superseding one. - Add an explicit pull_request_review_id correlation gate so a COMMENTED review whose feedback already lives in inline comments is not double-counted as a Category 3 item. - Define a single normalize(body) rule (whitespace collapse, quote-marker strip, 280-char truncation with U+2026) and reference it from both the Step 6 quote template and the Step 3 idempotency check, so re-runs don't post duplicate replies for long bodies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
andrescrz
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Update the
/comet:address-github-pr-commentsskill so it stops silently dropping PR-level reviews where feedback lives only in the reviewbody(e.g., aCHANGES_REQUESTEDreview submitted with no inline comments — these don't appear in GraphQLreviewThreadsor inpulls/{N}/comments/issues/{N}/comments). Triggered by missed feedback on PR #6507.Step 3 (Collect Pending Comments) now enumerates three feedback categories — inline review comments, issue thread comments, and PR-level review bodies — with explicit pending criteria for each:
pulls/{N}/reviewsbysubmitted_atdesc, group byuser.login, evaluate only the newest review per reviewer (so older reviews can't stay pending after a superseding one).pull_request_review_idassociation gate: aCOMMENTEDreview whose id is referenced by any inline comment isn't a Category 3 item — its feedback already lives in Category 1, so it's not double-counted.state=CHANGES_REQUESTEDnot later dismissed; orstate=COMMENTEDwith non-emptybody, zero attached inline comments, and no prior addressed-marker reply.Step 6 (Post Replies) introduces a new "PR-level Review Replies — Quote Reply on Issue Thread" section. Since these reviews have no thread to attach to (
in_reply_tois N/A), the skill posts a quote-reply onissues/{N}/comments. Both quote generation and the Step 3 idempotency check call the samenormalize(body)function (whitespace collapse, leading->strip, 280-char truncation, U+2026 ellipsis) — preventing duplicate replies on re-runs of long bodies.Step 7 (Resolve Threads) scope clarified — applies only to inline comments (Category 1). PR-level review bodies have no review thread to resolve; their acknowledgement is the quote-reply from Step 6.
Doc-only edit:
.agents/commands/comet/address-github-pr-comments.md(canonical source;.claude/commands/...is gitignored, regenerated locally). No regression to inline-only flow.Commits on this branch:
d2e310c80c— initial three-category restructure + quote-reply flowc2a3f2d4ee— tighten Category 3 dedup and shared quote normalization (addresses inline review feedback on this PR)Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
No automated tests — this is a skill spec / prompt-doc change with no executable code.
Manual verification plan:
/comet:address-github-pr-commentsagainst a PR that has aCHANGES_REQUESTEDreview with no inline comments (e.g., revisit PR [OPIK-6177] [BE] fix: dedupe by stable dataset_item_id in experiment comparison #6507) and confirm the review body is surfaced as a pending item.resolveReviewThread).COMMENTEDreview is not surfaced as Category 3 (already verified on this PR —pulls/6536/reviewsreturned oneCOMMENTEDwithbody=""and the new spec correctly filters it).Documentation
N/A — this PR itself is the documentation change (skill spec).
🤖 Generated with Claude Code