[OPIK-4449] [FE] Fix eval suite Assertions tab and Go to traces button#5752
Open
[OPIK-4449] [FE] Fix eval suite Assertions tab and Go to traces button#5752
Conversation
Replace Tag with Button+TooltipWrapper for the trace link in ExperimentItemContent, and guard openTrace with isFunction check to prevent crashes when the callback is undefined.
Rename FE types/fields from assertion_aggregations to assertion_scores to match the BE API response shape after PR #5716. The BE now serves per-assertion average pass rates as {name, value} instead of {name, pass_rate, passed_count, total_count}.
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fix two eval suite issues on CompareExperimentsPage:
assertion_aggregationstoassertion_scoreswith shape{name, value}, the FE silently dropped the data. Renamed FE types/fields to match the new BE contract.Buttonto a compactTagwith "Go to traces" label for consistency.Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
tsc --noEmit), test suite, code review agentsTesting
cd apps/opik-frontend && npx tsc --noEmit— passes with zero errorscd apps/opik-frontend && npm test -- --run— all tests pass (pre-existing failures inls-migrations/engine.test.tsunrelated)AssertionAggregation/assertion_aggregationsnamesDocumentation