[OPIK-4714] [FE] Edit dataset permission#5722
Open
anastasiapyzhik wants to merge 9 commits intomainfrom
Open
Conversation
apps/opik-frontend/src/components/pages/DatasetItemsPage/DatasetTagsList.tsx
Outdated
Show resolved
Hide resolved
apps/opik-frontend/src/v1/pages/EvaluationSuiteItemsPage/EvaluationSuiteItemsPage.tsx
Show resolved
Hide resolved
apps/opik-frontend/src/v1/pages/EvaluationSuiteItemsPage/EvaluationSuiteItemsPage.tsx
Show resolved
Hide resolved
aadereiko
approved these changes
Mar 20, 2026
Collaborator
aadereiko
left a comment
There was a problem hiding this comment.
The code LGTM :) Good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Add a new
canEditDatasetspermission to control edit-level access to datasets and evaluation suites in the frontend. This separates "edit" actions (add/edit items, expand with AI, manage tags, edit dataset metadata) from "delete" actions, enabling more granular role-based access control.Changes:
DATASET_EDITmanagement permission and wired it through the permissions providercanEditDatasetsshowDownloadprop)Change checklist
canEditDatasetspermission added toPermissionstype and defaultsDATASET_EDITenum value added toManagementPermissionsNamesuseUserPermissionhook andPermissionsProviderDatasetItemsActionsPanel— hides "Expand with AI", tag management, and delete buttonsDatasetRowActionsCell— hides "Edit" menu item, removesshowDownloadpropVersionHistoryTab— hides actions column when user cannot editEvaluationSuiteItemsPage— tags rendered as immutable when user cannot editEvaluationSuiteItemsTab— hides add item button, row actions, disables row clickEvaluationSuitesPage— hides actions column when no actions availableScreenshots
Testing
dataset_editpermission can see all edit actions (add, edit, expand, tags, delete items)dataset_editpermission cannot see edit-related actions but can still view datasets and exportIssues
OPIK-4714
Documentation
N/A