Skip to content

fix: improve install error when pre-release driver already installed#344

Merged
amoeba merged 2 commits intomainfrom
fix/340-install-prerelease-error
Apr 7, 2026
Merged

fix: improve install error when pre-release driver already installed#344
amoeba merged 2 commits intomainfrom
fix/340-install-prerelease-error

Conversation

@zeroshade
Copy link
Copy Markdown
Member

Summary

Fixes #340.

  • When a user runs dbc install <driver> without --pre for a driver that only has pre-release versions and is already installed, the error now says the driver is already installed (with its version) instead of saying it was "not found"
  • The original "not found (but prerelease versions filtered out)" error is preserved when the driver is not already installed
  • Adds a test that installs a pre-release driver, then verifies the improved error when re-installing without --pre

Before:

Error: driver `singlestore` not found (but prerelease versions filtered out); try: dbc install --pre singlestore

After:

Error: driver `singlestore` is already installed (version 0.1.0-beta.1); only pre-release versions are available for this driver; to update, use: dbc install --pre singlestore

@zeroshade zeroshade added this to the 0.3.0 milestone Apr 5, 2026
Copy link
Copy Markdown
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@amoeba amoeba requested a review from ianmcook April 6, 2026 19:32
@amoeba
Copy link
Copy Markdown
Member

amoeba commented Apr 6, 2026

@ianmcook tagged you for review in case you want to. The most likely path the user will follow here would be,

~/src/columnar-tech/dbc fix/340-install-prerelease-error
$ go run ./cmd/dbc install singlestore
Error: driver `singlestore` not found (but prerelease versions filtered out); try: dbc install --pre singlestore
exit status 1

~/src/columnar-tech/dbc fix/340-install-prerelease-error
$ go run ./cmd/dbc install --pre singlestore
[✓] searching
[✓] downloading
[✓] installing
[✓] verifying signature

Installed singlestore 0.1.0-beta.1 to /Users/bryce/Library/Application Support/ADBC/Drivers


~/src/columnar-tech/dbc fix/340-install-prerelease-error
$ go run ./cmd/dbc install singlestore
Error: driver `singlestore` is already installed (version 0.1.0-beta.1); only pre-release versions are available for this driver; to update, use: dbc install --pre singlestore
exit status 1

~/src/columnar-tech/dbc fix/340-install-prerelease-error
$ go run ./cmd/dbc install --pre singlestore

Driver singlestore 0.1.0-beta.1 already installed at /Users/bryce/Library/Application Support/ADBC/Drivers

@amoeba amoeba force-pushed the fix/340-install-prerelease-error branch from f0a4bae to 7ad43f8 Compare April 6, 2026 19:34
@amoeba amoeba deployed to snapshot April 6, 2026 19:34 — with GitHub Actions Active
@amoeba
Copy link
Copy Markdown
Member

amoeba commented Apr 6, 2026

Rebased to pick up the recent pre-commit config and pushed automatic fixes up.

@amoeba
Copy link
Copy Markdown
Member

amoeba commented Apr 6, 2026

The pre-commit config is running under pull_request_target so I'll fix that in a follow-up. It's clean when I run locally so this PR is merge-able.

@amoeba amoeba merged commit 47d886c into main Apr 7, 2026
11 of 13 checks passed
@amoeba amoeba deleted the fix/340-install-prerelease-error branch April 7, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dbc install error when installing already-installed pre-release driver without --pre

3 participants