Skip to content

Conversation

@zeroshade
Copy link
Member

closes #259

@ianmcook
Copy link
Member

@zeroshade what sets the x-dbc-latest header when a new dbc version is released?

@ianmcook
Copy link
Member

I think this should probably just fail silently if it can't fetch the latest available dbc version. Telling the user that it didn't succeed is not really helpful or actionable.

@ianmcook
Copy link
Member

@amoeba any clever ideas about how to make this less annoying for users who are making the conscious choice not to upgrade (at least not right now)?

Co-authored-by: Ian Cook <[email protected]>
@zeroshade
Copy link
Member Author

@zeroshade what sets the x-dbc-latest header when a new dbc version is released?

Cloudfront function on the distribution for downloading dbc (we use it for the install scripts). It maps latest -> the latest version. So I added a check for the case where the request is just / as the path

@zeroshade
Copy link
Member Author

I think this should probably just fail silently if it can't fetch the latest available dbc version. Telling the user that it didn't succeed is not really helpful or actionable.

That's currently the case. It fails silently if it fails. Notice in main.go we ignore the error returned if it's not nil and just move on

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked into how existing software implements such functionality, but I wonder if there are cases where distribution channels might want to disable such functionality?
I imagine there might be a need to be able to disable this functionality at build time.

@zeroshade
Copy link
Member Author

We could create a build flag and allow controlling whether it does this check with a build tag if everyone thinks that would be a good idea. @ianmcook @amoeba @esadek what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idea: Let the user know their version of dbc is out of date

4 participants