-
Notifications
You must be signed in to change notification settings - Fork 7
feat: notify user their version of dbc is out of date #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@zeroshade what sets the |
|
I think this should probably just fail silently if it can't fetch the latest available dbc version. Telling the user that it didn't succeed is not really helpful or actionable. |
|
@amoeba any clever ideas about how to make this less annoying for users who are making the conscious choice not to upgrade (at least not right now)? |
Co-authored-by: Ian Cook <[email protected]>
Cloudfront function on the distribution for downloading dbc (we use it for the install scripts). It maps |
That's currently the case. It fails silently if it fails. Notice in |
eitsupi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked into how existing software implements such functionality, but I wonder if there are cases where distribution channels might want to disable such functionality?
I imagine there might be a need to be able to disable this functionality at build time.
closes #259