Improve test coverage for tools, float, binary, geo and todo - issues…

[shiva-kumar04]

… 698

Closes issue

• contributes to Python: Improve test coverage in 5 places for production code #698

Description

Improves test coverage by adding tests for previously uncovered branches. Improves coverage from 96% to 98%

Focus areas:

• normalize_pytz
• vFloat.ical_value
• vBinary.hash
• vGeo.hash
• ToDo.duration

Checklist

• I've added a change log entry to CHANGES.rst.
• I've added or updated tests if applicable.
• I've run and ensured all tests pass locally by following Run tests.
• I've added or edited documentation, both as docstrings to be rendered in the API documentation and narrative documentation, as necessary.

Additional information

beforeCoverage.html

afterCoverage.html

[read-the-docs-community]

Documentation build overview

📚 icalendar | 🛠️ Build #32119795 | 📁 Comparing 91110ef against latest (d08bb43)

  🔍 Preview build  

Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted

File	Status
404.html	📝 modified
reference/changelog.html	📝 modified

[niccokunzmann]

Thanks, I added a few comments.
Also, please format the code: https://github.com/collective/icalendar/actions/runs/23376081732/job/68008197434?pr=1291

[stevepiercy]

@shiva-kumar04 would you please resolve merge conflicts? Take care with CHANGES.rst to ensure entries are preserved. Thank you!

[shiva-kumar04]

checks are waiting for long time, is there anything to be redone

[stevepiercy]

@shiva-kumar04 the expected checks only trigger after the pull request is approved, to save server resources.

Approval won't happen until you resolve the merge conflicts, to save human resources.

Please let us know, if you need assistance to resolve the merge conflicts. Thank you!

[stevepiercy]

Thanks for resolving the merge conflicts. I'll commit these changes.

[stevepiercy]

LGTM. @niccokunzmann would you review the changes you requested?

[stevepiercy]

Spoke too soon.

@shiva-kumar04 would you please resolve the two failing checks?

• https://github.com/collective/icalendar/actions/runs/23683933127/job/69000291879?pr=1291
• https://github.com/collective/icalendar/actions/runs/23683933093/job/69000286211?pr=1291

[niccokunzmann]

Here, one needs to remove the ()

>       assert vFloat(1.2).ical_value() == 1.2

ical_value is a property, not a method.

[niccokunzmann]

Thanks for your PR! It is almost ready to merge!

[shiva-kumar04]

@niccokunzmann @stevepiercy Thanks for your commments and guidance. Sorry for the delay in response, I'm looking into it and will update shortly

[shiva-kumar04]

I have rebased with the latest main and confirmed my changes pass all logic and formatting checks. Please help me in closing this request.

[niccokunzmann]

Thanks!

[shiva-kumar04]

@stevepiercy i think your approval is also required for the successful merge. Can you please approve.