ci: update wasmbrowsertest to a specific commit#514
Merged
mafredri merged 1 commit intocoder:masterfrom Jan 30, 2025
Merged
Conversation
Using latest wasn't getting the latest version of wasmbrowsertest, so we're now using a specific commit. Current version was failing due to timeouts, so we're updating to latest commit to see if it fixes the issue.
Contributor
Author
Contributor
Author
|
This repo had a similar issue, and it looks like they fixed it by updating the version as well: hajimehoshi/ebiten#2982 |
Contributor
Author
|
This problem looks like a flaky test, so I'm not entirely sure if this PR will actually fix the issue. The CI for this PR (#509) has now passed, even though |
mafredri
approved these changes
Jan 30, 2025
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
Weird, issue. Thanks for looking into it, I think it's good to lock down the version anyway, so let's hope this fixes it 🤞🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using latest wasn't getting the latest version of wasmbrowsertest, so we're now using a specific commit.
Current version was failing due to timeouts, so we're updating to latest commit to see if it fixes the issue.