Skip to content

TEF-345 Update pya deploy actions to wait on tax benefits backend#303

Merged
tahsinaislam merged 4 commits intomainfrom
TEF-345-update-pya-gyraffe-and-efiler-api-deploy-actions-to-wait-on-tax-benefit-backend-success
Apr 3, 2026
Merged

TEF-345 Update pya deploy actions to wait on tax benefits backend#303
tahsinaislam merged 4 commits intomainfrom
TEF-345-update-pya-gyraffe-and-efiler-api-deploy-actions-to-wait-on-tax-benefit-backend-success

Conversation

@tahsinaislam
Copy link
Copy Markdown
Contributor

@tahsinaislam tahsinaislam commented Apr 2, 2026

Link to pivotal/JIRA issue

Is PM acceptance required? (

  • No - merge after code review approval

What was done?

EXPOSE 8080
#ENV THRUSTER_HTTP_PORT=8080
EXPOSE 80
CMD ["./bin/thrust", "./bin/rails", "server"]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to test a deploy failure on this branch

Copy link
Copy Markdown
Contributor

@mrotondo mrotondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding of the WRSAT example, I believe that the distinct_id input & step that you added to this file should actually go in the "Deploy infrastructure" GHA in tax-benefits-backend. That way, the "Wait on Workflow" step you added here can actually use the distinct_id that's output by the remotely dispatched workflow to (somehow) wait until that workflow finishes.

Copy link
Copy Markdown
Contributor

@mrotondo mrotondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on this - I saw that you got a successful failure, that's awesome! Now that I actually check, it looks like the deploy GHA in tax-benefits-backend already has the distinct_id input & step, so no need to add them there or here.

I'll approve this PR since it's not really a blocker whether or not you want to add a distinct_id to this workflow. I don't know of any other workflow that we expect will ever wait on this one, but maybe there will be!

@tahsinaislam tahsinaislam merged commit 7ce51db into main Apr 3, 2026
4 checks passed
@tahsinaislam tahsinaislam deleted the TEF-345-update-pya-gyraffe-and-efiler-api-deploy-actions-to-wait-on-tax-benefit-backend-success branch April 3, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants