TEF-345 Update pya deploy actions to wait on tax benefits backend#303
Conversation
Co-authored-by: Drew Proebstel <[email protected]>
| EXPOSE 8080 | ||
| #ENV THRUSTER_HTTP_PORT=8080 | ||
| EXPOSE 80 | ||
| CMD ["./bin/thrust", "./bin/rails", "server"] |
There was a problem hiding this comment.
i wanted to test a deploy failure on this branch
mrotondo
left a comment
There was a problem hiding this comment.
From my understanding of the WRSAT example, I believe that the distinct_id input & step that you added to this file should actually go in the "Deploy infrastructure" GHA in tax-benefits-backend. That way, the "Wait on Workflow" step you added here can actually use the distinct_id that's output by the remotely dispatched workflow to (somehow) wait until that workflow finishes.
mrotondo
left a comment
There was a problem hiding this comment.
Update on this - I saw that you got a successful failure, that's awesome! Now that I actually check, it looks like the deploy GHA in tax-benefits-backend already has the distinct_id input & step, so no need to add them there or here.
I'll approve this PR since it's not really a blocker whether or not you want to add a distinct_id to this workflow. I don't know of any other workflow that we expect will ever wait on this one, but maybe there will be!
Co-authored-by: Drew Proebstel <[email protected]>
Link to pivotal/JIRA issue
Is PM acceptance required? (
What was done?