add makefile prefix, custom reqs cache key args#48
Merged
matt-codecov merged 1 commit intomainfrom Apr 8, 2025
Merged
Conversation
89f35a0 to
8d4e36b
Compare
8d4e36b to
fb85617
Compare
Swatinem
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for codecov/umbrella#30
previously i added
working_directoryto these workflows so that umbrella could make each one runcd apps/workeror similar at the beginning. it turns out, however, that we need to build requirements images in the umbrella root rather thanapps/workeretc. so this PR replacesworking_directorywith a newmake_target_prefixargument: if the workflow ordinarily callsmake build, umbrella can use this argument to make it callmake worker.buildunfortunately, i couldn't completely get rid of the old
working_directory. with the way things are set up, things likeapp.tarorjunit.xmlare still dumped inapps/worker. so i renamed the argumentoutput_directoryto match its new functionfinally, this PR adds the
reqs_cache_keyargument tobuild-app.ymlandself-hosted.yml. this allows umbrella to pass in a special cache key for its special requirements images which include an extra hash. if the argument isn't provided, the cache key is computed like normal.